Skip to content

[AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7024674 - #49521

Open
azure-sdk-automation[bot] wants to merge 11 commits into
mainfrom
sdkauto/azure-mgmt-fileshares-6952245
Open

azure-sdk-automation[bot] wants to merge 11 commits into
mainfrom
sdkauto/azure-mgmt-fileshares-6952245

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

SDK generation details

Note

This pull request was generated automatically.

Detail Value
TypeSpec source specification/fileshares/resource-manager/Microsoft.FileShares/FileShares/tspconfig.yaml at cec8aac
Pipeline run SDK Generation #7024674
Release plan Release plan #36883
Submitted by jlindamood@microsoft.com

Important

Complete the SDK release prerequisites before release.

…FileShares/FileShares/tspconfig.yaml', API Version: 2026-09-01, SDK Release Type: stable, and CommitSHA: 'cf4aa9847c9ac23bbe7c05c2c89b17ba10de9648' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6952245 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-6952245 [AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7016573 Oct 29, 2026
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Oct 29, 2026
The recordings were made at 2026-06-01, so playback failed after the 2026-09-01
regeneration. Re-record all hand-written tests live against the canary endpoint
(eastus2euap) and update the assets tag. Point the live-only CRUD test at the same
canary defaults as the other tests, since 2026-09-01 is only in the canary manifest.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The API-version documentation incorrectly advertises support for None, which causes get_limits() to fail, and the changelog omits the Python minimum-version increase from 3.9 to 3.10.

2 open issues
What changed in this PR

Regenerates azure-mgmt-fileshares for API version 2026-09-01 and prepares the stable 1.0.0 release.

Changes:

  • Adds managed identity, encryption, scale mode, HDD tier, and redundancy-conversion support.
  • Updates generated clients, request types, examples, and release metadata; raises the minimum Python version to 3.10.
  • Moves CRUD test defaults to the canary environment and updates recorded assets.

Paths below are relative to sdk/fileshares/azure-mgmt-fileshares/. Generated samples and tests are listed for completeness but excluded from detailed review under repository guidance.

File Description
tsp-location.yaml Pins the updated TypeSpec source commit.
tests/​test_fileshares_crud.py Uses canary endpoint and resource defaults.
README.md Updates authentication terminology to Microsoft Entra.
pyproject.toml Marks the package stable and requires Python 3.10+.
generated_tests/​test_file_shares_mgmt_informational_operations_operations.py Expands provisioning request fields.
generated_tests/​test_file_shares_mgmt_informational_operations_operations_async.py Mirrors async provisioning request changes.
generated_tests/​test_file_shares_mgmt_file_shares_operations.py Adds new properties and conversion test stubs.
generated_tests/​test_file_shares_mgmt_file_shares_operations_async.py Mirrors async properties and conversion stubs.
generated_samples/​private_link_resources_list_by_file_share.py Updates source-version comment only.
generated_samples/​private_link_resources_get.py Updates source-version comment only.
generated_samples/​private_endpoint_connections_list_by_file_share.py Updates source-version comment only.
generated_samples/​private_endpoint_connections_get.py Updates source-version comment only.
generated_samples/​private_endpoint_connections_delete.py Updates source-version comment only.
generated_samples/​private_endpoint_connections_create.py Updates source-version comment only.
generated_samples/​operations_list_minimum_set_gen.py Updates source-version comment only.
generated_samples/​operations_list_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_shares_update_maximum_set_gen.py Adds identity and encryption inputs.
generated_samples/​file_shares_start_redundancy_conversion_maximum_set_gen.py Adds a redundancy-conversion example.
generated_samples/​file_shares_list_by_subscription_minimum_set_gen.py Updates source-version comment only.
generated_samples/​file_shares_list_by_subscription_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_shares_list_by_parent_minimum_set_gen.py Updates source-version comment only.
generated_samples/​file_shares_list_by_parent_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_shares_get_redundancy_conversion_status_minimum_set_gen.py Adds a conversion-status example.
generated_samples/​file_shares_get_redundancy_conversion_status_maximum_set_gen.py Adds a conversion-status example.
generated_samples/​file_shares_get_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_shares_delete_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_shares_create_or_update_maximum_set_gen.py Adds identity, encryption, and scale mode.
generated_samples/​file_shares_check_name_availability_minimum_set_gen.py Updates source-version comment only.
generated_samples/​file_shares_check_name_availability_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_snapshot_update_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_snapshot_list_minimum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_snapshot_list_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_snapshot_get_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_snapshot_delete_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_snapshot_create_or_update_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_get_usage_data_minimum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_get_usage_data_maximum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_get_provisioning_recommendation_minimum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_get_provisioning_recommendation_maximum_set_gen.py Adds offer-selection inputs.
generated_samples/​file_share_get_limits_minimum_set_gen.py Updates source-version comment only.
generated_samples/​file_share_get_limits_maximum_set_gen.py Updates source-version comment only.
CHANGELOG.md Lists additions for version 1.0.0.
azure/​mgmt/​fileshares/​types.py Adds typed dictionary request definitions.
azure/​mgmt/​fileshares/​models/​_models.py Adds models and resource properties.
azure/​mgmt/​fileshares/​models/​_enums.py Adds encryption, identity, scale, and conversion enums.
azure/​mgmt/​fileshares/​models/​__init__.py Exports new models and enums.
azure/​mgmt/​fileshares/​aio/​operations/​_operations.py Updates async operations, typing, and paging headers.
azure/​mgmt/​fileshares/​aio/​_configuration.py Advances the async default API version.
azure/​mgmt/​fileshares/​aio/​_client.py Updates async client documentation and typing imports.
azure/​mgmt/​fileshares/​_version.py Sets package version to 1.0.0.
azure/​mgmt/​fileshares/​_utils/​serialization.py Refreshes generated serialization helpers.
azure/​mgmt/​fileshares/​_utils/​model_base.py Refreshes model serialization and deserialization.
azure/​mgmt/​fileshares/​_configuration.py Advances the synchronous default API version.
azure/​mgmt/​fileshares/​_client.py Updates client documentation and typing imports.
assets.json Points to updated test recordings.
apiview-properties.json Updates cross-language API mappings.
api.metadata.yml Adds API snapshot metadata.
_metadata.json Records updated API and generator versions.

Review effort: Balanced

…lists

The tests created shares in a resource group shared with other test suites, and listing by
subscription returns every share in the shared test subscription, so recordings captured
unrelated resources' names, IDs and host names.

- Default FILESHARES_TEST_RG to azsdk-python-fileshares-rg, used only by these tests.
- conftest.py: while recording, keep only that resource group's shares in recorded file
  share list responses.
- Re-recorded all tests against the canary endpoint and updated the assets tag.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 30, 2026 21:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Client documentation incorrectly advertises support for api_version=None, which causes operations to fail, and release notes omit the new Python 3.10+ requirement.

2 open issues
2 previously missed issues

In code that hasn't changed since last review

Low severity Document the dropped Python 3.9 support

sdk/​fileshares/​azure-mgmt-fileshares/​CHANGELOG.md:5

This release raises requires-python from 3.9 to 3.10, but the new 1.0.0 changelog only lists added features. Please add an entry explicitly stating that Python 3.9 is no longer supported so users can identify the compatibility change before upgrading.

Low severity Document the async client's actual API version default

sdk/​fileshares/​azure-mgmt-fileshares/​azure/​mgmt/​fileshares/​aio/​_client.py:71

The async client also advertises api_version=None, but its configuration preserves that value and operation validation rejects it; for example, start_redundancy_conversion raises a ValueError before sending a request. Please regenerate the documentation with the actual 2026-09-01 default and remove None from the supported values unless the fallback is implemented.

Review effort: Balanced

API version 2026-09-01 is not yet available in the public ARM manifest, so release this as a
beta instead of the first stable release: version 1.0.0b2, 'Development Status :: 4 - Beta'
and is_stable = false. A stable 1.0.0 follows once 2026-09-01 is publicly available.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 30, 2026 22:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The API metadata incorrectly labels prerelease 1.0.0b2 as stable 1.0.0, while documentation omits dropped Python 3.9 support and advertises an unsupported None API version.

3 open issues

Review effort: Balanced

…a and changelog fixes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 31, 2026 04:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The generated client documentation incorrectly advertises api_version=None as supported, although explicitly passing it causes operations such as get_limits to raise ValueError instead of using the default.

1 open issue
2 resolved since last review

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor
[Pilot] PR Pipeline Failure Analysis

What failed

Azure Pipeline build 7024664 (job: python - pullrequest, task: "Create APIView if API has changes") failed in the Detect-Api-Changes.ps1 PowerShell step with:

PowerShell exited with code '1'.
The term 'System.PullRequest.PullRequestNumber' is not recognized as a name of a cmdlet, function, script file, or executable program.
Relevant pipeline output
[command]/usr/bin/pwsh -NoLogo -NoProfile -NonInteractive -Command . '/mnt/vss/_work/_temp/cd625aa5-6c4f-4a42-a86c-b82ecd0aae07.ps1'
System.PullRequest.PullRequestNumber: /mnt/vss/_work/_temp/cd625aa5-6c4f-4a42-a86c-b82ecd0aae07.ps1:3
Line |
   3 |  ... 664 -PullRequestNumber $(System.PullRequest.PullRequestNumber) -RepoF ...
     |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The term 'System.PullRequest.PullRequestNumber' is not recognized as a
     | name of a cmdlet, function, script file, or executable program. Check
     | the spelling of the name, or if a path was included, verify that the
     | path is correct and try again.

##[error]PowerShell exited with code '1'.

Root cause

The step is defined in the shared pipeline template eng/common/pipelines/templates/steps/detect-api-changes.yml (line 22), which invokes Detect-Api-Changes.ps1 with -PullRequestNumber $(System.PullRequest.PullRequestNumber). Azure Pipelines did not substitute the $(System.PullRequest.PullRequestNumber) variable macro before the PowerShell script ran — it was passed through literally. PowerShell then tried to interpret the raw, unquoted token System.PullRequest.PullRequestNumber as a positional/command argument, producing "not recognized as a name of a cmdlet" and failing the step.

This indicates the System.PullRequest.PullRequestNumber predefined variable was not available/populated in this build's context, rather than an issue with any file changed in this PR. None of the 62 files modified in this PR touch eng/common/pipelines/ or the Detect-Api-Changes.ps1 script — the failure is in a shared engineering pipeline template unrelated to the azure-mgmt-fileshares SDK generation changes in this PR.

Recommended next steps

  • Re-run/retry the python - pullrequest pipeline — this is often transient when the System.PullRequest.* variable group isn't populated for a particular trigger/run.
  • If it recurs across multiple PRs, file an issue against eng/common/pipelines/templates/steps/detect-api-changes.yml to add a guard (e.g., quote the variable or skip the step when System.PullRequest.PullRequestNumber is empty) so a missing variable doesn't crash the step.
  • See https://aka.ms/ci-fix

Copilot detected the failing pipeline and generated the analysis above. To have it attempt a fix automatically, reply with @copilot please fix the failing pipeline on this PR.

Generated by Pipeline Analysis Next Steps · copilot · sonnet50 · 33.3 AIC · ⌖ 0.561 AIC · ⊞ 8.9K · ◷

@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7016573 [AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7024674 Nov 1, 2026
Copilot AI balanced review requested due to automatic review settings November 1, 2026 17:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Service-owner confirmation is needed before the stable 1.0.0 release because the changed CRUD-test comment identifies API 2026-09-01 as canary-only, and the supplied evidence does not establish production ARM availability.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@jlindamood

Copy link
Copy Markdown
Member

/azp run python - pullrequest

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@ChenxiJiang333 Chenxi Jiang (ChenxiJiang333) added the mgmt-review-needed PR for Mgmt SDK is ready to review label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Management SDK PR review

Review completeness: complete. Advisory only; not approval to merge.

Findings: None.

Unverified checks

Unverified checks: None.

Breaking-change attribution

Package: sdk/fileshares/azure-mgmt-fileshares | Release: 1.0.0 (2026-11-01)

Breaking-change attribution: No newly added or modified entries.

Review summary

Package Completed checks
sdk/fileshares/azure-mgmt-fileshares Management package discovery; Version consistency _version.py
CHANGELOG.md; Preview version _version.py
_metadata.json; Changelog date CHANGELOG.md; Stability flags _version.py
pyproject.toml; Initial client name (not applicable: The trusted release baseline confirms a previously released package.) CHANGELOG.md; Client signature _client.py
_client.py; Client name consistency _client.py
_client.py
README.md
pyproject.toml; README snippets README.md
_client.py; API-version drift

Copilot AI balanced review requested due to automatic review settings November 2, 2026 02:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changelog omits the increase in the minimum Python version from 3.9 to 3.10, leaving Python 3.9 users unaware that they can no longer install this release.

1 open issue

Review effort: Balanced

@ChenxiJiang333

Copy link
Copy Markdown
Member

Hi James Lindamood (@jlindamood), I noticed you tried to update the SDK version to beta while keeping the API version stable. Is there any context behind this change?

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 17:27
@jlindamood

Copy link
Copy Markdown
Member

API version 2026-09-01 is not available in every public region yet, so we're releasing all SDKs as beta until it reaches all regions. The release plan's SDK release type is beta. The post-merge regeneration ran without the release type and reset the version to 1.0.0, so I've restored 1.0.0b2.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because the wildcard can select multiple cached asset checkouts, risking deletion of shares from unrelated recordings and breaking their playback.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

…kout

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 17:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The canary-only API default needs service-owner deployment confirmation, while teardown-time recording filtering requires human security/privacy review of saved assets and failure paths.

No open issues 🎉

Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 21:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Service-owner confirmation of public ARM availability and GA readiness is needed because the stable release defaults to API 2026-09-01, which the updated tests describe as canary-only.

No open issues 🎉

Review effort: Balanced

@jlindamood

Copy link
Copy Markdown
Member

Following up: after discussing with the service owner, we're releasing all SDKs as stable for 2026-09-01, so this package is now 1.0.0 (11cef62).

@jlindamood James Lindamood (jlindamood) removed the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Nov 10, 2026
@jlindamood

Copy link
Copy Markdown
Member

Holding this PR: please don't merge or release yet. API version 2026-09-01 isn't production-ready, so the SDKs will ship stable once it is. I've removed the auto-release label for now.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants